Inside for most pumps is better as there is less of a chance to leak, external if the pump is a model that gives off way too much heat (not really a problem anymore with our efficient pumps) or external if you need extra head pressure for moving water to a different floor in the house (plumbing sump in a different room)