I don't see how you can have any legal complications as long as you are not selling it for money or using their code. The main idea would be able to communicate with other controller brands module/parts. You just need to be able to speak the language of the other controller brands. It is possible you could flash the firmware and use your own code. Also wouldn't hurt the other companies as people would buy some of their accessories. You will also always have the people who just want a finished, easy and polished product that will buy everything from the company. Basically, why re-invent the wheel every time on all the parts.
I might not be selling reef-pi, but the Apache 2 license thats reef-pi is under, is a permissive one, and allows anyone to modify and sell things based on reef-pi, with or without my consent.
reef-pi is not an embedded system software (stuff that runs on arduino or any microcontroller based installation) , its a full blown client/server thing that requires a full blown computer (like raspberry pi, beaglebone or macbook or thinkpads etc). There is no firmware involved whatsoever, we ride on the shoulder of giants (Linux, raspbian , go, react etc). Its a fundamentally different thing :-)
You are right, there are folks who would prefer to have a pre-built controller that will save the time, and not every one has the skill (and time) to build this. Also, unless the tools are available, the cost of building a DIY controller will be likely higher than a commercial one (due to the tools cost). My current thought process is to iteratively attack the biggest bottlenecks, like a PCB will solve a lot of circuit building hassle and save time, next a 3d printed or cnc fabricated enclosure will reduce another big chunk of time and effort. There are few companies who have expressed interest in reef-pi, and if we are lucky, I think we'll have pre-made reef-pi controller available from one of the commercial vendors.
Regarding re-inventing wheel: We have to. Consider this:
Unless we re-invent, we dont get to take benefit of all the technical advancement made in due time. It is also about knowing the process of building & making. I will not go into details (unless you all are interested :-) ), but reef-pi is very different ground up, and thats not only coming from software, it's about the hardware and above all the thriving opensource software /open hardware community that it belongs to. I aim to achieve several distinct things with reef-pi that simply not possible by retrofitting commercial controller. Philosophical differences are one part of it, but ther are other major technical hurdles.